On 1/6/2020 3:17 AM, Simon Horman wrote:
On Mon, Jan 06, 2020 at 11:38:58AM +0100, Ilya Maximets wrote:
Our Travis fails to build kernel module with recent kernel 4.14.162.
It'll be good if someone could take a look:
https://travis-ci.org/ovsrobot/ovs/jobs/632805584
ovs/datapath/linux/ip_tunnel.c: In function ‘rpl_tnl_update_pmtu’:
ovs/datapath/linux/ip_tunnel.c:270:3: error: too few arguments to function
‘skb_dst((const struct sk_buff *)skb)->ops->update_pmtu’
skb_dst(skb)->ops->update_pmtu(skb_dst(skb), NULL, skb, mtu);
^
ovs/datapath/linux/ip6_gre.c: In function ‘ip6erspan_tunnel_xmit’:
ovs/datapath/linux/ip6_gre.c:1092:3: error: too few arguments to function
‘dst->ops->update_pmtu’
dst->ops->update_pmtu(dst, NULL, skb, dst->dev->mtu);
I think a possible solution to this is to unconditionally call
skb_dst_update_pmtu(). I will work on a patch but I don't mind
if someone else wants to post one.
Simon,
if you haven't already written up a patch then I'll go ahead and take
care of this.
Thanks,
- Greg
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev