Bleep bloop.  Greetings Han Zhou, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 81 characters long (recommended limit is 79)
#83 FILE: ic/ovn-ic.8.xml:12:
      daemon which communicates with global interconnection databases 
IC_NB/IC_SB

WARNING: Line is 82 characters long (recommended limit is 79)
#125 FILE: ic/ovn-ic.8.xml:54:
    <xi:include href="lib/daemon.xml" 
xmlns:xi="http://www.w3.org/2003/XInclude"/>

WARNING: Line is 80 characters long (recommended limit is 79)
#128 FILE: ic/ovn-ic.8.xml:57:
    <xi:include href="lib/vlog.xml" xmlns:xi="http://www.w3.org/2003/XInclude"/>

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#283 FILE: ic/ovn-ic.c:86:
  --ovnnb-db=DATABASE       connect to ovn-nb database at DATABASE\n\

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#285 FILE: ic/ovn-ic.c:88:
  --ovnsb-db=DATABASE       connect to ovn-sb database at DATABASE\n\

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#287 FILE: ic/ovn-ic.c:90:
  --unixctl=SOCKET          override default control socket name\n\

WARNING: Comment with 'xxx' marker
#502 FILE: ic/ovn-ic.c:305:
    /* ovn-nb db. XXX: add only needed tables and columns */

WARNING: Comment with 'xxx' marker
#506 FILE: ic/ovn-ic.c:309:
    /* ovn-sb db. XXX: add only needed tables and columns */

WARNING: Line is 111 characters long (recommended limit is 79)
#1138 FILE: tutorial/ovs-sandbox:406:
    
PATH=$builddir/controller:$builddir/controller-vtep:$builddir/northd:$builddir/ic:$builddir/utilities:$PATH

Lines checked: 1178, Warnings: 14, Errors: 0


Please check this out.  If you feel there has been an error, please email 
[email protected]

Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to