Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 85 characters long (recommended limit is 79)
#54 FILE: utilities/ovn-ctl:112:
$DB_IC_NB_SYNC_FROM_PORT $ic_nb_active_conf_file
ovn_ic_nb_db.ctl
WARNING: Line is 85 characters long (recommended limit is 79)
#59 FILE: utilities/ovn-ctl:117:
$DB_IC_SB_SYNC_FROM_PORT $ic_sb_active_conf_file
ovn_ic_sb_db.ctl
WARNING: Line is 91 characters long (recommended limit is 79)
#198 FILE: utilities/ovn-ctl:494:
OVS_RUNDIR=${OVS_RUNDIR} start_ovn_daemon "$OVN_IC_PRIORITY"
"$OVN_IC_WRAPPER" "$@"
WARNING: Line is 80 characters long (recommended limit is 79)
#402 FILE: utilities/ovn-ctl:838:
restart_ic_ovsdb restart ovn interconnection ovsdb-server processes
WARNING: Line is 81 characters long (recommended limit is 79)
#403 FILE: utilities/ovn-ctl:839:
restart_ic_nb_ovsdb restart ovn ic-northbound db ovsdb-server
process
WARNING: Line is 81 characters long (recommended limit is 79)
#404 FILE: utilities/ovn-ctl:840:
restart_ic_sb_ovsdb restart ovn ic-southbound db ovsdb-server
process
WARNING: Line is 82 characters long (recommended limit is 79)
#418 FILE: utilities/ovn-ctl:855:
promote_ic_nb promote ovn ic-northbound db backup server to
active
WARNING: Line is 82 characters long (recommended limit is 79)
#419 FILE: utilities/ovn-ctl:856:
promote_ic_sb promote ovn ic-southbound db backup server to
active
WARNING: Line is 81 characters long (recommended limit is 79)
#420 FILE: utilities/ovn-ctl:857:
demote_ic_nb demote ovn ic-northbound db active server to
backup
WARNING: Line is 81 characters long (recommended limit is 79)
#421 FILE: utilities/ovn-ctl:858:
demote_ic_sb demote ovn ic-southbound db active server to
backup
WARNING: Line is 83 characters long (recommended limit is 79)
#432 FILE: utilities/ovn-ctl:880:
--ovn-manage-ovsdb=yes|no Whether or not the OVN NB/SB databases
should be
WARNING: Line is 85 characters long (recommended limit is 79)
#445 FILE: utilities/ovn-ctl:896:
--ovn-ic-log=STRING ovn-ic process logging params (default:
$OVN_IC_LOG)
WARNING: Line is 83 characters long (recommended limit is 79)
#446 FILE: utilities/ovn-ctl:897:
--ovn-ic-logfile=STRING ovn-ic process log file (default:
$OVN_IC_LOGFILE)
WARNING: Line is 85 characters long (recommended limit is 79)
#466 FILE: utilities/ovn-ctl:964:
--db-ic-nb-addr=ADDR OVN IC Northbound db ptcp address (default:
$DB_IC_NB_ADDR)
WARNING: Line is 82 characters long (recommended limit is 79)
#467 FILE: utilities/ovn-ctl:965:
--db-ic-nb-port=PORT OVN IC Northbound db ptcp port (default:
$DB_IC_NB_PORT)
WARNING: Line is 85 characters long (recommended limit is 79)
#468 FILE: utilities/ovn-ctl:966:
--db-ic-sb-addr=ADDR OVN IC Southbound db ptcp address (default:
$DB_IC_SB_ADDR)
WARNING: Line is 82 characters long (recommended limit is 79)
#469 FILE: utilities/ovn-ctl:967:
--db-ic-sb-port=PORT OVN IC Southbound db ptcp port (default:
$DB_IC_SB_PORT)
WARNING: Line is 83 characters long (recommended limit is 79)
#470 FILE: utilities/ovn-ctl:968:
--ovn-ic-nb-logfile=FILE OVN IC Northbound log file (default:
$OVN_IC_NB_LOGFILE)
WARNING: Line is 83 characters long (recommended limit is 79)
#471 FILE: utilities/ovn-ctl:969:
--ovn-ic-sb-logfile=FILE OVN IC Southbound log file (default:
$OVN_IC_SB_LOGFILE)
WARNING: Line is 108 characters long (recommended limit is 79)
#472 FILE: utilities/ovn-ctl:970:
--db-ic-nb-sync-from-addr=ADDR OVN IC Northbound active db tcp address
(default: $DB_IC_NB_SYNC_FROM_ADDR)
WARNING: Line is 105 characters long (recommended limit is 79)
#473 FILE: utilities/ovn-ctl:971:
--db-ic-nb-sync-from-port=PORT OVN IC Northbound active db tcp port (default:
$DB_IC_NB_SYNC_FROM_PORT)
WARNING: Line is 109 characters long (recommended limit is 79)
#474 FILE: utilities/ovn-ctl:972:
--db-ic-nb-sync-from-proto=PROTO OVN IC Northbound active db transport
(default: $DB_IC_NB_SYNC_FROM_PROTO)
WARNING: Line is 123 characters long (recommended limit is 79)
#475 FILE: utilities/ovn-ctl:973:
--db-ic-nb-create-insecure-remote=yes|no Create ptcp OVN IC Northbound remote
(default: $DB_IC_NB_CREATE_INSECURE_REMOTE)
WARNING: Line is 108 characters long (recommended limit is 79)
#476 FILE: utilities/ovn-ctl:974:
--db-ic-sb-sync-from-addr=ADDR OVN IC Southbound active db tcp address
(default: $DB_IC_SB_SYNC_FROM_ADDR)
WARNING: Line is 105 characters long (recommended limit is 79)
#477 FILE: utilities/ovn-ctl:975:
--db-ic-sb-sync-from-port=ADDR OVN IC Southbound active db tcp port (default:
$DB_IC_SB_SYNC_FROM_PORT)
WARNING: Line is 109 characters long (recommended limit is 79)
#478 FILE: utilities/ovn-ctl:976:
--db-ic-sb-sync-from-proto=PROTO OVN IC Southbound active db transport
(default: $DB_IC_SB_SYNC_FROM_PROTO)
WARNING: Line is 123 characters long (recommended limit is 79)
#479 FILE: utilities/ovn-ctl:977:
--db-ic-sb-create-insecure-remote=yes|no Create ptcp OVN IC Southbound remote
(default: $DB_IC_SB_CREATE_INSECURE_REMOTE)
WARNING: Line is 85 characters long (recommended limit is 79)
#484 FILE: utilities/ovn-ctl:982:
--db-ic-nb-cluster-local-proto=PROTO OVN_IC_Northbound cluster local db
transport \
WARNING: Line is 80 characters long (recommended limit is 79)
#486 FILE: utilities/ovn-ctl:984:
--db-ic-nb-cluster-remote-addr=ADDR OVN_IC_Northbound cluster remote address \
WARNING: Line is 81 characters long (recommended limit is 79)
#488 FILE: utilities/ovn-ctl:986:
--db-ic-nb-cluster-remote-port=PORT OVN_IC_Northbound cluster remote tcp port
\
WARNING: Line is 85 characters long (recommended limit is 79)
#496 FILE: utilities/ovn-ctl:994:
--db-ic-sb-cluster-local-proto=PROTO OVN_IC_Southbound cluster local db
transport \
WARNING: Line is 80 characters long (recommended limit is 79)
#498 FILE: utilities/ovn-ctl:996:
--db-ic-sb-cluster-remote-addr=ADDR OVN_IC_Southbound cluster remote address \
WARNING: Line is 81 characters long (recommended limit is 79)
#500 FILE: utilities/ovn-ctl:998:
--db-ic-sb-cluster-remote-port=PORT OVN_IC_Southbound cluster remote tcp port
\
WARNING: Line is 129 characters long (recommended limit is 79)
#506 FILE: utilities/ovn-ctl:1004:
--db-ic-nb-use-remote-in-db=yes|no OVN_IC_Northbound db listen on target
connection table (default: $DB_IC_NB_USE_REMOTE_IN_DB)
WARNING: Line is 129 characters long (recommended limit is 79)
#507 FILE: utilities/ovn-ctl:1005:
--db-ic-sb-use-remote-in-db=yes|no OVN_IC_Southbound db listen on target
connection table (default: $DB_IC_SB_USE_REMOTE_IN_DB)
WARNING: Line is 81 characters long (recommended limit is 79)
#720 FILE: utilities/ovn-ctl.8.xml:142:
<p><code>--db-ic-nb-cluster-local-proto=<var>PROTO
(tcp/ssl)</var></code></p>
WARNING: Line is 82 characters long (recommended limit is 79)
#723 FILE: utilities/ovn-ctl.8.xml:145:
<p><code>--db-ic-nb-cluster-remote-proto=<var>PROTO
(tcp/ssl)</var></code></p>
WARNING: Line is 81 characters long (recommended limit is 79)
#726 FILE: utilities/ovn-ctl.8.xml:148:
<p><code>--db-ic-sb-cluster-local-proto=<var>PROTO
(tcp/ssl)</var></code></p>
WARNING: Line is 82 characters long (recommended limit is 79)
#729 FILE: utilities/ovn-ctl.8.xml:151:
<p><code>--db-ic-sb-cluster-remote-proto=<var>PROTO
(tcp/ssl)</var></code></p>
Lines checked: 784, Warnings: 39, Errors: 0
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
