On 2/4/20 12:48 AM, Yi-Hung Wei wrote: > On Fri, Jan 31, 2020 at 2:07 AM Dumitru Ceara <[email protected]> wrote: >> >> On 1/29/20 7:58 PM, William Tu wrote: >>> On Fri, Dec 20, 2019 at 01:16:39PM -0800, Ben Pfaff wrote: >>>> On Fri, Dec 20, 2019 at 09:51:08AM -0800, Yi-Hung Wei wrote: >>>>> In connection tracking system, a connection is established if we >>>>> see packets from both directions. However, in userspace datapath's >>>>> conntrack, if we send a connection setup packet in one direction >>>>> twice, it will make the connection to be in established state. >>>>> >>>>> This patch fixes the aforementioned issue, and adds a system traffic >>>>> test for UDP and TCP traffic to avoid regression. >>>>> >>>>> Fixes: a489b16854b59 ("conntrack: New userspace connection tracker.") >>>>> Signed-off-by: Yi-Hung Wei <[email protected]> >>>>> --- >>> >>> LGTM. I applied this to master, and branch 2.13. >>> Thanks >>> William >>> >> >> Hi William, Yi-Hung, >> >> This patch breaks OVN switch load balancer system tests when running >> with the OVS userspace datapath. I only had a glance at the code and >> didn't dig into why exactly the tests fail yet but it's quite easy to >> reproduce: >> >> $ cd /tmp/ >> $ git clone https://github.com/openvswitch/ovs >> $ cd /tmp/ovs >> $ git checkout a867c010ee9183885ee9d3eb76a0005c075c4d2e >> $ ./boot.sh && ./configure && make -j8 >> $ cd /tmp/ >> $ git clone https://github.com/ovn-org/ovn >> $ cd /tmp/ovn/ >> $ ./boot.sh && ./configure --with-ovs-source=/tmp/ovs >> --with-ovs-build=/tmp/ovs && make -j8 >> $ make -j8 check-system-userspace TESTSUITEFLAGS="-k ovnlb" >> [...] >> system-ovn >> >> 7: ovn -- load-balancing FAILED >> (system-ovn.at:1121) >> 8: ovn -- load-balancing - IPv6 FAILED >> (system-ovn.at:1268) >> 9: ovn -- load-balancing - same subnet. FAILED >> (system-ovn.at:1389) >> 10: ovn -- load-balancing - same subnet. - IPv6 FAILED >> (system-ovn.at:1498) >> 11: ovn -- load balancing in gateway router ok >> 12: ovn -- load balancing in gateway router - IPv6 ok >> 13: ovn -- multiple gateway routers, load-balancing ok >> 14: ovn -- multiple gateway routers, load-balancing - IPv6 ok >> 15: ovn -- load balancing in router with gateway router port ok >> 16: ovn -- load balancing in router with gateway router port - IPv6 ok >> >> # Reverting commit a867c010ee9183885ee9d3eb76a0005c075c4d2e >> >> $ cd /tmp/ovs >> $ git checkout a867c010ee9183885ee9d3eb76a0005c075c4d2e~ >> $ make -j8 >> $ cd /tmp/ovn >> $ make -j8 check-system-userspace TESTSUITEFLAGS="-k ovnlb" >> [...] >> system-ovn >> >> 7: ovn -- load-balancing ok >> 8: ovn -- load-balancing - IPv6 ok >> 9: ovn -- load-balancing - same subnet. ok >> 10: ovn -- load-balancing - same subnet. - IPv6 ok >> 11: ovn -- load balancing in gateway router ok >> 12: ovn -- load balancing in gateway router - IPv6 ok >> 13: ovn -- multiple gateway routers, load-balancing ok >> 14: ovn -- multiple gateway routers, load-balancing - IPv6 ok >> 15: ovn -- load balancing in router with gateway router port ok >> 16: ovn -- load balancing in router with gateway router port - IPv6 ok >> >> Thanks, >> Dumitru > > > Hi Dumitru, > > Thanks for reporting this issue. I am not familiar with OVN and the > broken system tests, but I will take a look. > > -Yi-Hung >
Hi Yi-Hung, Please let me know if you need help. I can try to find a simpler way to reproduce the issue. Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
