> -----Original Message----- > From: Amber Hu <q...@vmware.com> > Sent: Tuesday, February 4, 2020 7:03 AM > To: Alin Serdean <aserd...@cloudbasesolutions.com>; d...@openvswitch.org > Cc: Qiong Wang <wqi...@vmware.com>; Wenyu Zhang > <wen...@vmware.com>; Jinjun Gao <jinj...@vmware.com> > Subject: [patch v3] datapath-windows: Append tunnel info to upcall for correct > template > > Formerly, there is no tunnel information appended in the upcall’s packet data, > which is expected by IPFIX in userspace to calculate the template for > exporting > the sampled flow record of on egress tunnel port. > To fix this, during performing OvsOutputUserspaceAction(), we would check > whether it is initiated by the sampling on egress tunnel which would be > indicated > by the attribute as OVS_USERSPACE_ATTR_EGRESS_TUN_PORT in the nested > attribute list. If so, we would append the tunKey in OvsForwardingContext > indexed by OVS_PACKET_ATTR_EGRESS_TUN_KEY to the upcall. > Besides, at this point, the source transport port and source ip address are > not > available in the structure, so we have to fill it in the way how the packet > would > be capsulated during performing OvsEncapGeneve(), which is following the > OvsOutputUserspaceAction() unfortunately. > I have tested the IPFIX functionality with the change, we could see the > template > is correct and the expected tunnel information could be packed in the IPFIX > packet finally. The traffic for test is generated by PING utility. > > From d727d051c9a44a4a93e5ee5f3da3ca9b125aad29 Mon Sep 17 00:00:00 > 2001 > From: Amber Hu <q...@vmware.com> > Date: Thu, 30 Jan 2020 18:01:32 -0800 > Subject: [PATCH v3] datapath-windows: Append tunnel info to upcall for correct > template >
Thank you for addressing the comments! Acked-by: Alin Gabriel Serdean <aserd...@ovn.org> _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
