From: Kees Cook <[email protected]> Date: Wed, 19 Feb 2020 22:23:09 -0800
> Variables declared in a switch statement before any case statements > cannot be automatically initialized with compiler instrumentation (as > they are not part of any execution flow). With GCC's proposed automatic > stack variable initialization feature, this triggers a warning (and they > don't get initialized). Clang's automatic stack variable initialization > (via CONFIG_INIT_STACK_ALL=y) doesn't throw a warning, but it also > doesn't initialize such variables[1]. Note that these warnings (or silent > skipping) happen before the dead-store elimination optimization phase, > so even when the automatic initializations are later elided in favor of > direct initializations, the warnings remain. > > To avoid these problems, move such variables into the "case" where > they're used or lift them up into the main function body. > > net/openvswitch/flow_netlink.c: In function ‘validate_set’: > net/openvswitch/flow_netlink.c:2711:29: warning: statement will never be > executed [-Wswitch-unreachable] > 2711 | const struct ovs_key_ipv4 *ipv4_key; > | ^~~~~~~~ > > [1] https://bugs.llvm.org/show_bug.cgi?id=44916 > > Signed-off-by: Kees Cook <[email protected]> Applied. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
