On Wed, Feb 12, 2020 at 08:38:51AM +0000, Vishal Deep Ajmera wrote: > > To me it looks like we will need an equivalent of flow_wc_map() which is > > less stricter than > > flow_wildcards_init_for_packet() if we want to add this check in > > xlate_wc_finish(). > > > > Let me know if the current solution has issues. I can try to move this > check > > to > > xlate_wc_finish() otherwise. > > Hi Ben, > > Any thoughts on this? Should I write an equivalent of flow_wc_map() and use > it in xlate_wc_finish() > or we use a stricter version i.e. flow_wildcards_init_for_packet() and use > in revalidate_ukey__?
My big problem for review here is that I don't understand the motivation for moving the code around. Sure, it *works*, but why? Why did you think to do it? _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
