On Thu, Mar 12, 2020 at 10:04:30AM -0700, William Tu wrote:
[...]
> static inline bool
> -dp_packet_ip_checksum_valid(const struct dp_packet *p)
> -{
> - return (p->mbuf.ol_flags & PKT_RX_IP_CKSUM_MASK) ==
> - PKT_RX_IP_CKSUM_GOOD;
The indentation here is correct
> -}
> -
> -static inline bool
> -dp_packet_ip_checksum_bad(const struct dp_packet *p)
> -{
> - return (p->mbuf.ol_flags & PKT_RX_IP_CKSUM_MASK) ==
> - PKT_RX_IP_CKSUM_BAD;
Also correct.
[...]
> +static inline bool
> +dp_packet_hwol_l4_is_tcp(const struct dp_packet *b)
> +{
> + return (*dp_packet_ol_flags_ptr(b) & DP_PACKET_OL_TX_L4_MASK) ==
> + DP_PACKET_OL_TX_TCP_CKSUM;
That seems to be missing a space?
> +}
> +
> +/* Returns 'true' if packet 'b' is marked for UDP checksum offloading. */
> +static inline bool
> +dp_packet_hwol_l4_is_udp(struct dp_packet *b)
> +{
> + return (*dp_packet_ol_flags_ptr(b) & DP_PACKET_OL_TX_L4_MASK) ==
> + DP_PACKET_OL_TX_UDP_CKSUM;
Same here
> +}
> +
> +/* Returns 'true' if packet 'b' is marked for SCTP checksum offloading. */
> +static inline bool
> +dp_packet_hwol_l4_is_sctp(struct dp_packet *b)
> +{
> + return (*dp_packet_ol_flags_ptr(b) & DP_PACKET_OL_TX_L4_MASK) ==
> + DP_PACKET_OL_TX_SCTP_CKSUM;
And here.
--
fbl
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
