Hi Ben:
Thanks for reviewing!
One point that we should confirm with you: if --id && --row-uuid
both specified, we should use UUID from --row-uuid to create table, am I right ?
Also, we should add test in which ovsdb unit test file ?(ovs-vsctl.at or
ovsdb-execution.at)
Thanks
Best Regards
Mail：[email protected]
发件人: Ben Pfaff
时间: 2020/03/14(星期六)02:30
收件人: Tao YunXiang;
抄送人: ovs-dev;Liu Chang;Han Zhou;
主题: Re: [ovs-dev] [PATCH v5] db-ctl-base: add uuid specified method for create
cmdOn Mon, Mar 09, 2020 at 05:20:18PM +0800, Tao YunXiang wrote:
> Commit a529e3cd1f (ovsdb-server: Allow OVSDB clients to specify the
> UUID for inserted rows) solves ovsdb-client specifing the UUID for
> insert operation. OVSDB now can support directly using uuid to identify
> a row. But for xxxctl tool,specifying uuid when creating a row is not
> yet supported . This patch tried to specify uuid when creating a row
> by the ctl tools. A new parameter --row_uuid is added to setup row's UUID.
> e.g. ovn-nbctl --row_uuid=3da0398b-a5a8-4bc9-808d-fa662865138f create
> logical_switch name='abc'
>
> Co-authored-by: Liu Chang <[email protected]>
> Signed-off-by: Tao YunXiang <[email protected]>
> Signed-off-by: Liu Chang <[email protected]>
> CC: Han Zhou <[email protected]>
> CC: Ben Pfaff<[email protected]>
Thanks for the patch.
I think that this feature interacts badly with the existing --id
option. If --id and --row-uuid are specified, then the UUID for the
symbol specified on --id should be taken from --row-uuid, but I do not
think that happens in this case.
Please add a test.
Thanks,
Ben.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
