On 3/17/2020 4:31 PM, William Tu wrote:
Coverity CID 279274 reports leaking previously allocated
'error' buffer when 'return xasprintf("input too big");'.

Cc: Usman Ansari <[email protected]>
Signed-off-by: William Tu <[email protected]>
---
  lib/ofp-actions.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index ddef3b0c8780..ef8b2b4527f9 100644
--- a/lib/ofp-actions.c
+++ b/lib/ofp-actions.c
@@ -6657,6 +6657,7 @@ parse_CT(char *arg, const struct ofpact_parse_params *pp)
      }
if (ofpbuf_oversized(pp->ofpacts)) {
+        free(error);
          return xasprintf("input too big");
      }

Reviewed-by: Greg Rose <[email protected]>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to