Hi Ben, Thanks for your review. I have summited v6. The new change has fixed the bug, and add a unit test in ovs-vsctl.at. Please review it again.
Thanks, Yun -------------- [email protected] >I guess it's a bug. > >Have you posted the code you tested? Please post a v6 that includes the >test that fails. > >On Wed, Mar 18, 2020 at 11:03:45PM +0800, Timo_Liu wrote: >> > >Hi Ben: > > > > > When using both --id and --row_uuid, I have found the specified uuid only >worked for table whose "is_root" flag is true. For non root table, such as >mirror table, when we execute table create with --id and --row_uuid，the json >transaction includes two ops: insert mirror table (with uuid specified by >--row_uuid)， and update Bridge table column, But for the update operation, the >row->uuid is not the specified uuid any more. > > I don't know why the "uuid-name" key for "insert" operation can tranmit >its uuid value to row->new_datum for "update" operatoin. Can you give me some >advice ? > >Thanks > >Timo > > > > > > > > >Re: Re: [ovs-dev] [PATCH v5] db-ctl-base: add uuid specified method for create >cmdOn Mon, Mar 16, 2020 at 09:31:48AM +0800, Timo_Liu wrote: >> One point that we should confirm with you: if --id && >> --row-uuid both specified, we should use UUID from --row-uuid to >> create table, am I right ? > >Yes. > >> Also, we should add test in which ovsdb unit test file ?(ovs-vsctl.at or >> ovsdb-execution.at) > >I think that ovs-vsctl.at is a good place for testing ovs-vsctl >features. > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
