On Wed, Mar 18, 2020 at 5:37 PM Ben Pfaff <[email protected]> wrote: > > On Wed, Mar 18, 2020 at 05:32:03PM -0700, Usman Ansari wrote: > > Suggested-by: Ben Pfaff <[email protected]> > > > > Coverity reports a false positive below: > > Incorrect expression, Assign_where_compare_meant: use of "=" > > where "==" may have been intended. > > Fixed it by rewriting '(NODE = NULL)' as '((NODE = NULL), false)'. > > "make check" passes for this change > > Coverity reports 80 errors resolved > > > > Signed-off-by: Usman Ansari <[email protected]> > > Thanks. > > This doesn't apply. "git am" says: > > Applying: hmap.h: Fix Coverity false positive > error: corrupt patch at line 14 > Patch failed at 0001 hmap.h: Fix Coverity false positive > hint: Use 'git am --show-current-patch' to see the failed patch > When you have resolved this problem, run "git am --continue". > If you prefer to skip this patch, run "git am --skip" instead. > To restore the original branch and stop patching, run "git am --abort". > > Also, all tags go at the bottom of the commit message, that is, > Suggested-by is in the wrong place. The committer documentation has > some more rules for tags.
Hi Usman, You can also setup travis CI tests for your patch, see Documentation/topics/testing.rst And provide a link to the CI test result. Regards, William _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
