On Mon, Mar 23, 2020 at 12:47:38PM -0700, William Tu wrote: > On Mon, Mar 23, 2020 at 12:32 PM Ben Pfaff <[email protected]> wrote: > > > > On Mon, Mar 23, 2020 at 12:23:10PM -0700, William Tu wrote: > > > On Mon, Mar 23, 2020 at 11:55 AM William Tu <[email protected]> wrote: > > > > > > > > On Mon, Mar 23, 2020 at 11:33 AM Dave Tucker <[email protected]> > > > > wrote: > > > > > > > > > > Hi all! > > > > > > > > > > Current master branch is failing to compile under clang. > > > > > The problem was introduced in this commit (applied 4 hours ago). > > > > > https://github.com/openvswitch/ovs/commit/ecd4a8fcdff2ebf35cdb36355167d34e99df6dd5 > > > > > > > > > > lib/vlog.c:618:12: error: reading variable 'log_fd' requires holding > > > > > mutex > > > > > 'log_file_mutex' [-Werror,-Wthread-safety-analysis] > > > > > return log_fd; > > > > > ^ > > > > > > > > > > Based on the error I'd suggest reverting the patch and reworking it to > > > > > safely acquire/release log_file_mutex. > > > > > > > > > > > Hi Dave, > > > > > > I'm thinking about how to skip this lock(log_file_mutex), since this is > > > already > > > in SIGSEGV signal handling and afterward it coredump. > > > > You can mark vlog_get_fd() as OVS_REQUIRES(log_file_mutex) and then the > > caller OVS_NO_THREAD_SAFETY_ANALYSIS. > > Hi Dave and Ben, > Thanks! It works ok now. > Should I submit a revert and a new one with this fix? > or just submit a patch to fix it?
I'd just submit a fix patch. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
