On Tue, Mar 24, 2020 at 1:11 PM Ben Pfaff <[email protected]> wrote: > > On Tue, Mar 24, 2020 at 09:25:41AM +0800, Tonghao Zhang wrote: > > On Mon, Mar 16, 2020 at 12:06 PM Tonghao Zhang <[email protected]> > > wrote: > > > > > > On Mon, Mar 16, 2020 at 11:07 AM Yanqin Wei <[email protected]> wrote: > > > > > > > > Hi Xiangxia, > > > > > > > > The meter id is allocated by id_pool, which can always return the > > > > lowest available id. > > > Yes, I added 70000+ meters, and it works fine. > > > > There is a light scalable data struct which supports direct address > > > > lookup. It can achieve several times performance improvement than > > > > cmap_find. And it has not copy memory when expanding. > > > > https://patchwork.ozlabs.org/patch/1253447/ > > > > > > > > I suggest using this light data struct for >65535 meter instance. Would > > > > you like to take a look at it? > > > Yes, and I also wait Ilya to review, and offer a suggestion. > > Hi maintainers, > > Will you have a plan to help me to review those patches, thanks. > > I know that I skipped over this because I was waiting for v3 using > idpool. Hi Ben, The meter id is allocated by id_pool in ofproto-dpif layer(meter_set function use the id_pool_alloc_id to allocate it). I guess what Yanqin mean is that I should use the patches[1] he sent, to compare the performance with cmap. The patches of Yanqin are not in upstream, but I use the meter cache to address the issue.
[1] - https://patchwork.ozlabs.org/patch/1253447/ -- Best regards, Tonghao _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
