On Fri, May 1, 2020 at 10:18 PM Han Zhou <[email protected]> wrote: > Build fails due to flake8 errors: > === > ../tests/test-tcp-rst.py:20:1: F401 'sys' imported but unused > ../tests/test-tcp-rst.py:25:80: E501 line too long (85 > 79 characters) > ../tests/test-tcp-rst.py:36:80: E501 line too long (90 > 79 characters) > Makefile:2944: recipe for target 'flake8-check' failed > make[1]: *** [flake8-check] Error 1 > === > > Fixes: b4b6817 ("Fix conntrack entry leaks because of TCP RST packets not > sent to conntrack.") > Signed-off-by: Han Zhou <[email protected]> >
Thanks for fixing this. I need to check why it didn't fail in my system. Acked-by: Numan Siddique <[email protected]> Numan > --- > tests/test-tcp-rst.py | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/tests/test-tcp-rst.py b/tests/test-tcp-rst.py > index 6f96c57..553c51d 100644 > --- a/tests/test-tcp-rst.py > +++ b/tests/test-tcp-rst.py > @@ -17,12 +17,12 @@ > # resets the connection. > import argparse > import socket > -import sys > import struct > import time > > parser = argparse.ArgumentParser(description='') > -parser.add_argument("--src-port", type=int, default=11337, help="source > port to use") > +parser.add_argument("--src-port", type=int, default=11337, > + help="source port to use") > parser.add_argument("--dst-port", type=int, help="dst port to use") > parser.add_argument("--dst-ip", help="server ip to use") > args = parser.parse_args() > @@ -33,5 +33,6 @@ sock.connect(server_address) > l_onoff = 1 > l_linger = 0 > time.sleep(1) > -sock.setsockopt(socket.SOL_SOCKET, socket.SO_LINGER, struct.pack('ii', > l_onoff, l_linger)) > +sock.setsockopt(socket.SOL_SOCKET, socket.SO_LINGER, > + struct.pack('ii', l_onoff, l_linger)) > sock.close() > -- > 2.1.0 > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
