LGTM, thanks.

Reviewed-by: Yifeng Sun <[email protected]>



On Tue, May 12, 2020 at 8:23 AM William Tu <[email protected]> wrote:

> Clang reports:
> tests/oss-fuzz/miniflow_target.c:209:26: error: suggest braces around \
> initialization of subobject
>       [-Werror,-Wmissing-braces]
>           struct flow flow2 = {0};
>
> Fix it by using memset.
>
> Cc: Bhargava Shastry <[email protected]>
> Cc: Yifeng Sun <[email protected]>
> Signed-off-by: William Tu <[email protected]>
> ---
>  tests/oss-fuzz/miniflow_target.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/oss-fuzz/miniflow_target.c
> b/tests/oss-fuzz/miniflow_target.c
> index 393443061e85..50b8b0e64237 100644
> --- a/tests/oss-fuzz/miniflow_target.c
> +++ b/tests/oss-fuzz/miniflow_target.c
> @@ -206,8 +206,9 @@ test_minimask_combine(struct flow *flow)
>          struct minimask minicombined;
>          uint64_t storage[FLOW_U64S];
>      } m;
> -    struct flow flow2 = {0};
> +    struct flow flow2;
>
> +    memset(&flow2, 0, sizeof flow2);
>      mask.masks = *flow;
>      minimask = minimask_create(&mask);
>
> --
> 2.7.4
>
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to