On Wed, May 20, 2020 at 8:52 AM Daniel Alvarez <dalva...@redhat.com> wrote: > > ovs-ctl started to add the hostname as external-id [0] at some point. > > However, this can be problematic as if it's already set by an external > entity it will get overwritten. In RHEL systems, systemd will invoke > ovs-ctl to start OVS and that will overwrite it to the hostname of the > machine. > > For OVN this can have a big impact because if, for whatever reason the > hostname changes and the host gets restarted, ovn-controller won't > claim the ports back leaving the workloads unaccessible. > > Also, it makes sense to leave this untouched as 1) it's an external_id, > so it will actually let external entities to configure it (unlike now), > and 2) it's optional. In the case of OVN, if the external-id doesn't > exist, it'll default to its hostname so nothing should get broken by > this change. > > [0] https://mail.openvswitch.org/pipermail/ovs-dev/2016-March/312054.html > > Signed-off-by: Daniel Alvarez <dalva...@redhat.com> > --- > utilities/ovs-ctl.in | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in > index 8c5cd7032..87fc4934f 100644 > --- a/utilities/ovs-ctl.in > +++ b/utilities/ovs-ctl.in > @@ -35,17 +35,6 @@ insert_mod_if_required () { > ovs_kmod_ctl insert > } > > -set_hostname () { > - # 'hostname -f' needs network connectivity to work. So we should > - # call this only after ovs-vswitchd is running. > - if test X$FULL_HOSTNAME = Xyes; then > - hn="$(hostname -f)" || hn="$(uname -n)" > - else > - hn="$(uname -n)" > - fi > - ovs_vsctl set Open_vSwitch . external-ids:hostname="$hn" > -} > - > set_system_ids () { > set ovs_vsctl set Open_vSwitch . > > @@ -225,7 +214,6 @@ start_forwarding () { > if test X"$OVS_VSWITCHD" = Xyes; then > do_start_forwarding || return 1 > fi > - set_hostname & > return 0 > } > > -- > > _______________________________________________ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hi Daniel, I believe there are OpenStack based OVN users already depends on this. (And we had also add the --no-full-hostname option so that it will set the short name, so that it matches with openstack's "requested-chassis" setting which uses nova compute node name.) For the scenarios that this behavior is not desired, I think it is better to add a new option to override it, such as "--no-hostname", so that existing environment won't get impacted. What do you think? Thanks, Han _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
