On 5/7/20 1:20 PM, Dumitru Ceara wrote: > This series contains: > - patch1: update to the monitor_cond_change documentation in ovsdb-server to > reflect what updates are sent when monitor_cond_since method is used. > - patch2: fix for a bug that could cause client IDLs to end up in inconsistent > states when using OVSDB_MONITOR_V3. > - patch3: a generic recovery mechanism which triggers an IDL retry with fast > resync disabled in case the IDL ended up in an inconsistent state. > > CC: Han Zhou <[email protected]> > CC: Andy Zhou <[email protected]> > CC: Ilya Maximets <[email protected]> > Fixes: 403a6a0cb003 ("ovsdb-idl: Fast resync from server when connection > reset.") > Fixes: db2b5757328c ("lib: add monitor2 support in ovsdb-idl.") > Signed-off-by: Dumitru Ceara <[email protected]> >
Hi Han, Ilya, Just to make sure this didn't go under your radar, it would be great to get some feedback about this version. Thanks, Dumitru > Dumitru Ceara (3): > ovsdb-server.7: Mention update3 as replies to monitor_cond_change. > ovsdb-idl: Avoid inconsistent IDL state with OVSDB_MONITOR_V3. > ovsdb-idl: Force IDL retry when missing updates encountered. > > > Documentation/ref/ovsdb-server.7.rst | 6 + > lib/ovsdb-idl-provider.h | 8 + > lib/ovsdb-idl.c | 185 > +++++++++++++++++++++++++++++----- > tests/ovsdb-idl.at | 56 ++++++++++ > 4 files changed, 223 insertions(+), 32 deletions(-) > > > --- > V5: > - Address Ilya and Han's comments: > - Change approach to avoid large number of IDL clients disabling fast > resync and reconnecting at the same time. We now maintain per table > acked/requested/new conditions. > - Add unit test triggerring the issue fixed in patch 2. > V4: > - Address Ilya's comments: > - split in series (doc fix + bug fix + recovery mechanism). > - use uuid_zero() instead of memset. > - move clearing of db->last_id to ovsdb_idl_restart_fsm() and update > condition such that we cover all cases. > V3: > - Change commit title. > - Update commit message. > - Fix monitor_cond_since ovsdb-idl implementation. > V2: > - Address Mark's comments: > - change the error log message to reflect the action taken. > - use ovsdb_error() instead of ovsdb_syntax_error(). > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
