Bleep bloop. Greetings Linhaifeng, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Linhaifeng <haifeng....@huawei.com> needs to sign off.
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or committers: Haifeng Lin <haifeng....@huawei.com>
Lines checked: 130, Warnings: 1, Errors: 1
build:
depbase=`echo lib/poll-loop.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I.
-I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall
-Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
-Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
-Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
-Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror -g
-O2 -MT lib/poll-loop.lo -MD -MP -MF $depbase.Tpo -c -o lib/poll-loop.lo
lib/poll-loop.c &&\
mv -f $depbase.Tpo $depbase.Plo
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include
-I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare
-Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
-Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
-Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow
-Werror -Werror -g -O2 -MT lib/poll-loop.lo -MD -MP -MF lib/.deps/poll-loop.Tpo
-c lib/poll-loop.c -o lib/poll-loop.o
depbase=`echo lib/process.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I.
-I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall
-Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
-Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
-Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
-Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror -g
-O2 -MT lib/process.lo -MD -MP -MF $depbase.Tpo -c -o lib/process.lo
lib/process.c &&\
mv -f $depbase.Tpo $depbase.Plo
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include
-I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare
-Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
-Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
-Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow
-Werror -Werror -g -O2 -MT lib/process.lo -MD -MP -MF lib/.deps/process.Tpo -c
lib/process.c -o lib/process.o
depbase=`echo lib/pvector.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I.
-I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall
-Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
-Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
-Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
-Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror -g
-O2 -MT lib/pvector.lo -MD -MP -MF $depbase.Tpo -c -o lib/pvector.lo
lib/pvector.c &&\
mv -f $depbase.Tpo $depbase.Plo
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include
-I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare
-Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
-Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
-Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow
-Werror -Werror -g -O2 -MT lib/pvector.lo -MD -MP -MF lib/.deps/pvector.Tpo -c
lib/pvector.c -o lib/pvector.o
lib/pvector.c: In function 'pvector_publish__':
lib/pvector.c:210:12: error: implicit declaration of function
'vsrcu_get_protected' [-Werror=implicit-function-declaration]
struct pvector_impl *old = vsrcu_get_protected(struct pvector_impl *,
^
lib/pvector.c:210:52: error: expected expression before 'struct'
struct pvector_impl *old = vsrcu_get_protected(struct pvector_impl *,
^
cc1: all warnings being treated as errors
make[2]: *** [lib/pvector.lo] Error 1
make[2]: Leaving directory
`/var/lib/jenkins/jobs/0day_robot_upstream_build_from_pw/workspace'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
`/var/lib/jenkins/jobs/0day_robot_upstream_build_from_pw/workspace'
make: *** [all] Error 2
Please check this out. If you feel there has been an error, please email
acon...@redhat.com
Thanks,
0-day Robot
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
