On 6/9/20 7:10 PM, Numan Siddique wrote: > > > On Mon, Jun 8, 2020 at 9:39 PM Dumitru Ceara <[email protected] > <mailto:[email protected]>> wrote: > > On 6/8/20 3:50 PM, [email protected] <mailto:[email protected]> wrote: > > From: Numan Siddique <[email protected] <mailto:[email protected]>> > > > > This patch adds partial support of incremental processing of > datapath binding. > > If a datapath is deleted, then a full recompute is triggered if that > > datapath is present in the 'local_datapaths' hmap of runtime data. > > > > Acked-by: Mark Michelson <[email protected] > <mailto:[email protected]>> > > Acked-by: Han Zhou <[email protected] <mailto:[email protected]>> > > Signed-off-by: Numan Siddique <[email protected] <mailto:[email protected]>> > > Looks good to me. > > Acked-by: Dumitru Ceara <[email protected] <mailto:[email protected]>> > > > > Thanks Dumitru, Han and Mark for the reviews. > > I applied the first 3 patches of this series (addressing the review > comments) to master and also applied to branch-20.06. > > @Han - If you have any additional comments on these patches please let > me know. I'll have follow up patches. > > I'll update v11 of this series addressing the review comments from Dumitru. > > Thanks > Numan >
Hi Numan, I spotted a bug introduced by these 3 patches. The following scenario is now broken: ovn-nbctl lr-add rtr ovn-nbctl lrp-add rtr rtr-ls 00:00:00:00:01:00 42.42.42.1/24 ovn-nbctl ls-add ls ovn-nbctl lsp-add ls ls-rtr ovn-nbctl lsp-set-addresses ls-rtr 00:00:00:00:01:00 ovn-nbctl lsp-set-type ls-rtr router ovn-nbctl lsp-set-options ls-rtr router-port=rtr-ls ovn-nbctl lsp-add ls vm1 ovn-nbctl lsp-set-addresses vm1 00:00:00:00:00:01 ovn-nbctl lsp-add ls vm2 ovn-nbctl lsp-set-addresses vm2 00:00:00:00:00:02 ip netns add vm1 ovs-vsctl add-port br-int vm1 -- set interface vm1 type=internal ip link set vm1 netns vm1 ip netns exec vm1 ip link set vm1 address 00:00:00:00:00:01 ip netns exec vm1 ip addr add 42.42.42.2/24 dev vm1 ip netns exec vm1 ip link set vm1 up ovs-vsctl set Interface vm1 external_ids:iface-id=vm1 ip netns add vm2 ovs-vsctl add-port br-int vm2 -- set interface vm2 type=internal ip link set vm2 netns vm2 ip netns exec vm2 ip link set vm2 address 00:00:00:00:00:02 ip netns exec vm2 ip addr add 42.42.42.3/24 dev vm2 ip netns exec vm2 ip link set vm2 up ovs-vsctl set Interface vm2 external_ids:iface-id=vm2 # Works ip netns exec vm1 ping 42.42.42.3 -c 1 # Restart ovn-controller ovn-ctl restart_controller # Doesn't work ip netns exec vm1 ping 42.42.42.3 -c 1 # Delete port bindings ovn-sbctl destroy port_binding vm1 ovn-sbctl destroy port_binding vm2 # Works ip netns exec vm1 ping 42.42.42.3 -c 1 Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
