On Thu, Jun 18, 2020 at 2:00 PM Gabriele Cerami <[email protected]> wrote:
> On 17 Jun, Numan Siddique wrote: > > On Wed, Jun 17, 2020 at 3:26 PM Lorenzo Bianconi < > > [email protected]> wrote: > > > > > Set packet length in lr_in_chk_pkt_len router pipeline instead of > > > gw interface MTU since ovs kernel datapath usually works on L2 frames > > > > > > Fixes: 7d42c146be ("ovn: Generate ICMPv4 packet in router pipeline for > > > larger packets") > > > Signed-off-by: Lorenzo Bianconi <[email protected]> > > > --- > > > northd/ovn-northd.c | 4 ++-- > > > tests/ovn.at | 33 ++++++++++++++++++--------------- > > > 2 files changed, 20 insertions(+), 17 deletions(-) > > > > > > diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c > > > index b8c9e9325..53d5bf245 100644 > > > --- a/northd/ovn-northd.c > > > +++ b/northd/ovn-northd.c > > > @@ -10076,7 +10076,7 @@ build_lrouter_flows(struct hmap *datapaths, > struct > > > hmap *ports, > > > ds_clear(&actions); > > > ds_put_format(&actions, > > > REGBIT_PKT_LARGER" = check_pkt_larger(%d);" > > > - " next;", gw_mtu); > > > + " next;", gw_mtu + 18); > > > > > > > Hi Lorenzo, > > > > Thanks for the fix. Can you please add the comment why 18. May be a macro > > instead of "18" number. > > > > Maybe it's also worth modifying the comment here > https://github.com/ovn-org/ovn/blob/master/northd/ovn-northd.c#L10103 +1. Thanks Numan > > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
