On 6/22/2020 10:04 AM, Ilya Maximets wrote:
On 6/21/20 1:19 PM, Eli Britstein wrote:
The function of adding patterns by requested matches checks that it
consumed all the required matches, and err if not. This nullify the
purpose of the validation function. Future supported matches will only
change the pattern parsing code.
I think that validation function here is to speed up the process in case
of unsupported offloading patterns. It saves time for all the not needed
memory allocations and copies. With this change we will construct all the
patterns and only in the end will realize that we don't need them as the
flow can not be offloaded.
I know, and agree. However, the "save time" is negligible, comparing to
more complicated code.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
