On Wed, Jun 24, 2020 at 9:21 PM Dumitru Ceara <[email protected]> wrote:
> The first three patches refactor the ARP/NS responder code for logical > routers in order to make it easier for patch #4 to configure the flows > with different priorities depending on logical port type. > > Suggested-by: Han Zhou <[email protected]> > Reported-by: Girish Moodalbail <[email protected]> > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-discuss/2020-June/050186.html > Signed-off-by: Dumitru Ceara <[email protected]> > > Dumitru Ceara (4): > ovn-northd: Store ETH address of router inport in xxreg0. > ovn-northd: Refactor ARP/NS responder in router pipeline. > ovn-northd: Refactor NAT address parsing. > ovn-northd: Minimize number of ARP/NS responder flows for DNAT. > Hi Dumitru, Thanks for this patch series. I didn't review them thoroughly. I've few comments. 1. Looks like reg0 and xxreg0 are already used in the router pipeline. I think it's better to use a different register (xxreg1 may be). I'd suggest adding a new macro REG_IP_ROUTING (or something more meaningful) instead of using reg0/xxreg0 in the existing code in the lr_in_ip_input/lr_in_arp_resolve stages. 2. Does patch 2 require updating the ovn-northd.8.xml ? 3. For patches which modify the logical flows, can you please add a few test cases in ovn-northd.at. That would also help me while reviewing the code :) Thanks Numan > > northd/ovn-northd.8.xml | 38 ++- > northd/ovn-northd.c | 565 > ++++++++++++++++++++++++++++------------------- > tests/ovn.at | 8 - > 3 files changed, 361 insertions(+), 250 deletions(-) > > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
