On Wed, Jun 10, 2020 at 04:49:45PM -0300, Flavio Leitner wrote:
> The annotation OVS_NO_THREAD_SAFETY_ANALYSIS and OVS_LOCKABLE are
> not part of the list, so ctags can't find functions using them.
>
> The annotation list comes from a regex and to include more items
> make the regex more difficult to read and maintain. Convert to a
> static list because it isn't supposed to change much and there
> is no standard names.
>
> Also add a comment to remind to keep the list up-to-date.
>
> Signed-off-by: Flavio Leitner <[email protected]>
Hi Flavio,
Instead of a static list, how about adding
sed -n -e 's/^#define \(OVS_[A-Z_]\+\)(\.\.\.)$/\1+/p' \
-e 's/^#define \(OVS_[A-Z_]\+\)$/\1+/p' include/openvswitch/compiler.h
So with the 2nd sed command, it creates
OVS_NO_RETURN+
OVS_UNUSED+
OVS_WARN_UNUSED_RESULT+
OVS_LOCKABLE+
OVS_GUARDED+
OVS_NO_THREAD_SAFETY_ANALYSIS+
OVS_PACKED_ENUM+
Which covers the OVS_NO_THREAD_SAFETY_ANALYSIS+ and others.
I'm also ok keeping it static, if so, should we add these above?
Thanks
William
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
