> -----Original Message----- > From: William Tu <[email protected]> > Sent: Sunday, July 5, 2020 3:06 PM > To: Van Haaren, Harry <[email protected]> > Cc: ovs-dev <[email protected]>; Stokes, Ian <[email protected]>; > Ilya > Maximets <[email protected]>; Federico Iezzi <[email protected]> > Subject: Re: [PATCH v6 0/6] DPCLS Subtable ISA Optimization > > On Thu, Jul 2, 2020 at 10:42 AM Harry van Haaren > <[email protected]> wrote: > > > > v6 work done: > > - Fix as --64 unrecognized option > > - Fix build issues with avx512 library changes > > - Fix files left in build dir after distclean > > - Fix CPU arch dependant RTE_CPUFLAG_ usage > > > > Thanks William & Ian for review & help on v5. > > All known issues are fixed and working here.
<snip cover letter details> > > Harry van Haaren (6): > > dpif-netdev: implement subtable lookup validation. > > dpif-netdev: add subtable lookup prio set command. > > dpif-netdev: add subtable-lookup-prio-get command. > > dpdk: enable cpu feature detection. > > dpif-lookup: add avx512 gather implementation. > > docs/dpdk/bridge: add datapath performance section. > > > > The v6 looks good to me. It would be great if there is another pair of > eyes on this series. > It's a little hard for me to understand the avx512 gather > implementation (patch5), > but the idea of using autovalidator and it passes our test cases give > me more confidence > that it is correct. > > Acked-by: William Tu <[email protected]> I'm happy to see the Autovalidator concept in practice working well, it is likely a development/testing model to re-use in future for similar types of work to ensure consistency and validity of SIMD code. Thanks for your multiple reviews of the series over the last months. -Harry _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
