Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 91 characters long (recommended limit is 79)
#1866 FILE: lib/lacp.c:1160:
lacp_get_sub_stats(const struct lacp *lacp, const void *sub_, struct
lacp_sub_stats *stats)
WARNING: Line is 186 characters long (recommended limit is 79)
#2350 FILE: lib/ovs-actions.xml:792:
<syntax><code>bundle(</code><var>fields</var><code>,
</code><var>basis</var><code>, </code><var>algorithm</var><code>, ofport,
subs:</code><var>port</var>...<code>)</code></syntax>
WARNING: Line is 220 characters long (recommended limit is 79)
#2351 FILE: lib/ovs-actions.xml:793:
<syntax><code>bundle_load(</code><var>fields</var><code>,
</code><var>basis</var><code>, </code><var>algorithm</var><code>, ofport,
</code><var>dst</var><code>,
subs:</code><var>port</var>...<code>)</code></syntax>
WARNING: Line is 152 characters long (recommended limit is 79)
#2389 FILE: lib/ovs-actions.xml:871:
<var>sub</var> = { <var>i</var> such that <var>weights</var>[<var>i</var>]
>= <var>weights</var>[<var>j</var>] for all <var>j</var> != <var>i</var> }
WARNING: Line lacks whitespace around operator
#2581 FILE: ofproto/bond.c:138:
sub-interface. It will be reset to false after
ERROR: Improper whitespace around control block
#2731 FILE: ofproto/bond.c:513:
HMAP_FOR_EACH(sub, hmap_node, &bond->subs) {
WARNING: Comment with 'xxx' marker
#3384 FILE: ofproto/bond.c:1266:
* XXX This is O(n**2) in the number of subs but it could be O(n lg n)
ERROR: Inappropriate spacing in pointer declaration
#3911 FILE: ofproto/bond.c:1910:
e->sub = get_enabled_sub(CONST_CAST(struct bond*, bond));
WARNING: Line is 86 characters long (recommended limit is 79)
#4098 FILE: ofproto/bond.h:75:
void bond_sub_register(struct bond *, void *sub_, ofp_port_t ofport, struct
netdev *);
WARNING: Line is 84 characters long (recommended limit is 79)
#4455 FILE: ofproto/ofproto.c:1394:
ofproto_port_get_lacp_stats(const struct ofport *port, struct lacp_sub_stats
*stats)
WARNING: Line is 80 characters long (recommended limit is 79)
#4479 FILE: ofproto/ofproto.h:391:
int ofproto_port_get_lacp_stats(const struct ofport *, struct lacp_sub_stats *);
Lines checked: 5778, Warnings: 9, Errors: 2
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
