Hi Jeff,
On Tue, Jul 07, 2020 at 09:41:00PM +0000, Jeff Squyres (jsquyres) wrote: > On Jul 2, 2020, at 4:17 PM, Flavio Leitner <[email protected]> wrote: > > On Thu, Jun 25, 2020 at 02:03:34PM -0700, Jeff Squyres via dev wrote: [...] > >> diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at > >> index e3402e7b8..808200800 100644 > >> --- a/tests/ofproto-dpif.at > >> +++ b/tests/ofproto-dpif.at > >> @@ -29,12 +29,16 @@ AT_CHECK([ovs-appctl revalidator/wait]) > >> OVS_VSWITCHD_STOP > >> AT_CLEANUP > >> > >> -AT_SETUP([ofproto-dpif - active-backup bonding]) > >> -# Create br0 with interfaces p1, p2 and p7, creating bond0 with p1 and p2 > >> -# and br1 with interfaces p3, p4 and p8. > >> -# toggle p1,p2 of bond0 up and down to test bonding in active-backup mode. > >> +AT_SETUP([ofproto-dpif - active-backup bonding (with primary)]) > >> + > >> +dnl Create br0 with interfaces p1, p2 and p7, creating bond0 with p1 and > >> +dnl p2 (p1 as primary) and br1 with interfaces p3, p4 and p8. > >> +dnl toggle p1,p2 of bond0 up and down to test bonding in active-backup > >> mode. > >> +dnl With p1 down and p2 up/active, bring p1 back up. Since p1 is the > >> primary, > >> +dnl it should become active. > >> OVS_VSWITCHD_START( > >> - [add-bond br0 bond0 p1 p2 bond_mode=active-backup --\ > >> + [add-bond br0 bond0 p1 p2 bond_mode=active-backup \ > >> + other_config:bond-primary=p1 -- \ > >> set interface p1 type=dummy options:pstream=punix:$OVS_RUNDIR/p1.sock > >> ofport_request=1 -- \ > >> set interface p2 type=dummy options:pstream=punix:$OVS_RUNDIR/p2.sock > >> ofport_request=2 -- \ > >> add-port br0 p7 -- set interface p7 ofport_request=7 type=dummy -- \ > >> @@ -45,9 +49,202 @@ OVS_VSWITCHD_START( > >> add-port br1 p3 -- set interface p3 type=dummy > >> options:stream=unix:$OVS_RUNDIR/p1.sock ofport_request=3 -- \ > >> add-port br1 p4 -- set interface p4 type=dummy > >> options:stream=unix:$OVS_RUNDIR/p2.sock ofport_request=4 -- \ > >> add-port br1 p8 -- set interface p8 ofport_request=8 type=dummy --]) > >> +AT_CHECK([ovs-appctl vlog/set dpif:dbg dpif_netdev:dbg]) > >> WAIT_FOR_DUMMY_PORTS([p3], [p4]) > >> +OVS_WAIT_UNTIL([test -n "`ovs-appctl bond/show | grep 'active-backup > >> primary: p1'`"]) > >> + > >> + > >> +AT_CHECK([ovs-ofctl add-flow br0 action=normal]) > >> +AT_CHECK([ovs-ofctl add-flow br1 action=normal]) > >> +ovs-appctl netdev-dummy/set-admin-state up > > > > Missing the interface name? > > This is from the original bonding test that I copied. > > When no interface name is specified, the command still runs successfully and > reports "OK". > > "ovs-appctl list-commands" shows "netdev-dummy/set-admin-state [netdev] > up|down", which implies that the device name is optional. > > It looks like not specifying the interface name brings up *all* the > interfaces. From the context, I think that is what was desired...? Right, I forgot about that. Thanks, -- fbl _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
