Re: [ovs-dev] [PATCH v1 1/1] dpdk: Use DPDK 19.11.2 release.

Fri, 10 Jul 2020 09:23:46 -0700 



On 7/10/2020 4:55 PM, Kevin Traynor wrote:

On 06/07/2020 16:50, Ian Stokes wrote:

Modify travis linux build script to use DPDK 19.11.2 stable release and
update docs to reference 19.11.2 stable release.

Signed-off-by: Ian Stokes <[email protected]>
---
  .travis/linux-build.sh                   | 2 +-
  Documentation/faq/releases.rst           | 2 +-
  Documentation/intro/install/dpdk.rst     | 8 ++++----
  Documentation/topics/dpdk/vhost-user.rst | 6 +++---
  NEWS                                     | 5 ++++-
  5 files changed, 13 insertions(+), 10 deletions(-)



userspace-tso.rst says:

When the NIC performing the segmentation is using the i40e DPDK PMD, a fix
must be included in the DPDK build, otherwise TSO will not work. The fix can
be found on `DPDK patchwork`__.

__ https://patches.dpdk.org/patch/64136/

This fix is expected to be included in the 19.11.1 release. When OVS
migrates
to this DPDK release, this limitation can be removed.
---

The commit is in 19.11.2 (see below), so can this be removed now or you
want to keep as info for someone using 19.11.0 ? Either way the last
paragraph deserves a little update. Other than that lgtm.


commit 6b08d9b3331625a9b4c598d5520bc5fc27fce147
Author: Xiaoyun Li <[email protected]>
Date:   Thu Dec 26 14:45:44 2019 +0800

     net/i40e: fix Tx when TSO is enabled

     [ upstream commit 29b2ba82c4c94df1975d0cb9c5c23feef99cf6a3 ]




Ah, good catch, I think we can remove it as we're recommending a new 
version now that has been validated and contains the fix.


Cheers for the review.

Ian



$ git tag --contains 6b08d9b333162 | grep 19.11.2
v19.11.2


diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh
index 02615a8ec..e0a065291 100755
--- a/.travis/linux-build.sh
+++ b/.travis/linux-build.sh
@@ -170,7 +170,7 @@ fi

  
  if [ "$DPDK" ] || [ "$DPDK_SHARED" ]; then

      if [ -z "$DPDK_VER" ]; then
-        DPDK_VER="19.11"
+        DPDK_VER="19.11.2"
      fi
      install_dpdk $DPDK_VER
      if [ "$CC" = "clang" ]; then
diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst
index e5cef3915..7c826f239 100644
--- a/Documentation/faq/releases.rst
+++ b/Documentation/faq/releases.rst
@@ -194,7 +194,7 @@ Q: What DPDK version does each Open vSwitch release work 
with?
      2.10.x       17.11.4
      2.11.x       18.11.6
      2.12.x       18.11.6
-    2.13.x       19.11.0
+    2.13.x       19.11.2
      ============ =======

  
  Q: Are all the DPDK releases that OVS versions work with maintained?

diff --git a/Documentation/intro/install/dpdk.rst 
b/Documentation/intro/install/dpdk.rst
index dbf88ec43..90eaa8aa2 100644
--- a/Documentation/intro/install/dpdk.rst
+++ b/Documentation/intro/install/dpdk.rst
@@ -42,7 +42,7 @@ Build requirements
  In addition to the requirements described in :doc:`general`, building Open
  vSwitch with DPDK will require the following:

  
-- DPDK 19.11

+- DPDK 19.11.2

  
  - A `DPDK supported NIC`_
  
@@ -71,9 +71,9 @@ Install DPDK

  #. Download the `DPDK sources`_, extract the file and set ``DPDK_DIR``::

  
         $ cd /usr/src/

-       $ wget https://fast.dpdk.org/rel/dpdk-19.11.tar.xz
-       $ tar xf dpdk-19.11.tar.xz
-       $ export DPDK_DIR=/usr/src/dpdk-19.11
+       $ wget https://fast.dpdk.org/rel/dpdk-19.11.2.tar.xz
+       $ tar xf dpdk-19.11.2.tar.xz
+       $ export DPDK_DIR=/usr/src/dpdk-stable-19.11.2
         $ cd $DPDK_DIR

  
  #. (Optional) Configure DPDK as a shared library

diff --git a/Documentation/topics/dpdk/vhost-user.rst 
b/Documentation/topics/dpdk/vhost-user.rst
index c6c6fd8bd..4bc5aef59 100644
--- a/Documentation/topics/dpdk/vhost-user.rst
+++ b/Documentation/topics/dpdk/vhost-user.rst
@@ -392,9 +392,9 @@ To begin, instantiate a guest as described in 
:ref:`dpdk-vhost-user` or
  DPDK sources to VM and build DPDK::

  
      $ cd /root/dpdk/

-    $ wget https://fast.dpdk.org/rel/dpdk-19.11.tar.xz
-    $ tar xf dpdk-19.11.tar.xz
-    $ export DPDK_DIR=/root/dpdk/dpdk-19.11
+    $ wget https://fast.dpdk.org/rel/dpdk-19.11.2.tar.xz
+    $ tar xf dpdk-19.11.2.tar.xz
+    $ export DPDK_DIR=/root/dpdk/dpdk-stable-19.11.2
      $ export DPDK_TARGET=x86_64-native-linuxapp-gcc
      $ export DPDK_BUILD=$DPDK_DIR/$DPDK_TARGET
      $ cd $DPDK_DIR
diff --git a/NEWS b/NEWS
index 0116b3ea0..162fbc991 100644
--- a/NEWS
+++ b/NEWS
@@ -23,7 +23,10 @@ Post-v2.13.0
     - Tunnels: TC Flower offload
       * Tunnel Local endpoint address masked match are supported.
       * Tunnel Romte endpoint address masked match are supported.
-
+   - DPDK:
+     * OVS validated with DPDK 19.11.2, due to the inclusion of fixes for
+       CVE-2020-10722, CVE-2020-10723, CVE-2020-10724, CVE-2020-10725 and
+       CVE-2020-10726, this DPDK version is strongly recommended to be used.

  
  v2.13.0 - 14 Feb 2020

  ---------------------




_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev






















					Reply via email to