> -----Original Message-----
> From: Stokes, Ian <ian.sto...@intel.com>
> Sent: Friday, August 7, 2020 1:29 AM
> To: Eli Britstein <el...@mellanox.com>; Finn, Emma <emma.f...@intel.com>;
> d...@openvswitch.org; Xing, Beilei <beilei.x...@intel.com>; Guo, Jia
> <jia....@intel.com>
> Cc: i.maxim...@ovn.org
> Subject: RE: [PATCH] netdev-offload-dpdk: Fix for broken ethernet matching
> HWOL for XL710 NIC
>
> > On 8/6/2020 6:17 PM, Emma Finn wrote:
> > > The following 2 commits introduced changes which caused a regression
> > > for XL710 devices and functionality ceases for partial offload as a
> > > result.
> > > 864852a0624a ("netdev-offload-dpdk: Fix Ethernet matching for type
> > > only.")
> > > a79eae87abe4 ("netdev-offload-dpdk: Remove pre-validate of patterns
> > > function.")
> > OVS is vendor agnostic. That kind of workaround belongs in intel PMD
> > in dpdk, not in OVS.
>
> Hi Eli,
>
> Yes OVS looks to be vendor agnostic, but this code I believe was already in
> place and working for this usecase. As such it's removal introduced a
> regression from an OVS point of view between the releases.
>
> We have had examples in the past where workarounds are permissible if there
> is a clear path to fixing this in the future on the DPDK side (which is what I
> suggest here) (for example scatter gather support for MTUs in the past raised
> similar issue where we hand to handle specific NIC until the next DPDK LTS
> release).
>
> So my suggestion is to re-instate the original workaround and remove its when
> fixed in the next DPDK LTS which supports the change for i40e at the PMD
> layer or if it's backported to the next 19.11 stable release which would be
> validated for use with OVS.
>
> I've included the i40e DPDK maintainers here for their thoughts also.
>
> @Beilei/Jia Is this something we can look at to introduce in the i40e PMD?
Hi Ian,
Sorry I'm not very clear about what's the relationship between the three OVS
patches
(864852a0624a, a79eae87abe4, this fix patch) and DPDK issue. What's the i40e
issue?
Did you create a JIRA to track it?
BR，
Beilei
>
> Regards
> Ian
>
> > >
> > > Fixed by partial reversion of these changes.
> > >
> > > Signed-off-by: Emma Finn<emma.f...@intel.com>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
