On Fri, Aug 21, 2020 at 08:50:49AM -0700, Gregory Rose wrote: > > > On 8/21/2020 4:32 AM, Ilya Maximets wrote: > > On 8/20/20 5:56 PM, Gregory Rose wrote: > > > > > > > > > On 8/18/2020 9:41 PM, Flavio Leitner wrote: > > > > > > > > Right, but there is no sense in having ovs-check-dead-ifs.in packaged > > > > with execution permission. So, this is definitely a packaging issue. > > > > > > > > Assuming that you want to package the sources, then you need to tell > > > > RPM to ignore them, because they are not normal installable files. > > > > > > > > The following line tells RPM to ignore files under your sources > > > > directory: > > > > %global __brp_mangle_shebangs_exclude_from > > > > /usr/src/openvswitch-2.13.1.rhel82.39060899 > > > > > > > > Most probably you need to replace those versions with RPM macros. > > > > > > > > fbl > > > > > > > > > > Hi Flavio, > > > > > > Thank you - this did the trick. Our internal build team has a script > > > that adds this line to the rhel/openvswitch-dkms.spec.in file and the > > > build now passes without problems. > > > > > > Your help is much appreciated! > > > > Good to know that it works! > > > > BTW, I think that half of this patch is still valid, i.e. we probably > > still need to fix shebangs for actual python files: > > > > ofproto/ipfix-gen-entities | 4 ++-- > > ovsdb/dot2pic | 4 ++-- > > ovsdb/ovsdb-doc | 4 ++-- > > python/build/soutil.py | 4 ++-- > > tests/ovsdb-monitor-sort.py | 16 > > ++++++++++++++-- > > tests/sendpkt.py | 4 ++-- > > tests/test-l7.py | 4 ++-- > > tests/uuidfilt.py | 18 > > +++++++++++++++++- > > xenserver/etc_xapi.d_plugins_openvswitch-cfg-update | 4 ++-- > > xenserver/opt_xensource_libexec_interface-reconfigure | 2 +- > > xenserver/usr_share_openvswitch_scripts_ovs-xapi-sync | 4 ++-- > > > > Otherwise we coud have issues with unit tests and some other things on > > systems > > without 'python' symlink. > > > > Would you mind submitting v2? > > > > Best regards, Ilya Maximets. > > > > Hi Ilya, > > I'll be happy to do that.
It seems we don't want to remove the executable permission and the shebang will be @PYTHON@, so we can exclude that as mentioned in the doc[1]. I think the line fixing rhel/openvswitch-dkms.spec.in could also proposed to fix the spec for everyone, then no one needs to run any scripts. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/ -- fbl _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
