On Fri, Aug 21, 2020 at 6:50 AM Greg Rose <[email protected]> wrote: > > From: Tonghao Zhang <[email protected]> > > Upstream commit: > commit 4c76bf696a608ea5cc555fe97ec59a9033236604 > Author: Tonghao Zhang <[email protected]> > Date: Fri Nov 1 22:23:53 2019 +0800 > > net: openvswitch: don't unlock mutex when changing the user_features fails > > Unlocking of a not locked mutex is not allowed. > Other kernel thread may be in critical section while > we unlock it because of setting user_feature fail. > > Fixes: 95a7233c4 ("net: openvswitch: Set OvS recirc_id from tc chain > index") > Cc: Paul Blakey <[email protected]> > Signed-off-by: Tonghao Zhang <[email protected]> > Tested-by: Greg Rose <[email protected]> > Acked-by: William Tu <[email protected]> > Acked-by: Pravin B Shelar <[email protected]> > Signed-off-by: David S. Miller <[email protected]> > > Cc: Tonghao Zhang <[email protected]> > Signed-off-by: Greg Rose <[email protected]> Reviewed-by: Tonghao Zhang <[email protected]> > --- > datapath/datapath.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/datapath/datapath.c b/datapath/datapath.c > index 1235c4e..c222ef8 100644 > --- a/datapath/datapath.c > +++ b/datapath/datapath.c > @@ -1746,6 +1746,7 @@ static int ovs_dp_cmd_new(struct sk_buff *skb, struct > genl_info *info) > ovs_dp_reset_user_features(skb, info); > } > > + ovs_unlock(); > goto err_destroy_meters; > } > > @@ -1762,7 +1763,6 @@ static int ovs_dp_cmd_new(struct sk_buff *skb, struct > genl_info *info) > return 0; > > err_destroy_meters: > - ovs_unlock(); > ovs_meters_exit(dp); > err_destroy_ports_array: > kfree(dp->ports); > -- > 1.8.3.1 >
-- Best regards, Tonghao _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
