On Mon, Sep 07, 2020 at 01:53:11PM +0200, Ilya Maximets wrote: > On 9/4/20 9:25 PM, Flavio Leitner wrote: > > On Fri, Sep 04, 2020 at 08:07:41PM +0200, Ilya Maximets wrote: > >> On 9/4/20 5:09 PM, Flavio Leitner wrote: > >>> On Fri, Sep 04, 2020 at 12:54:39AM +0200, Ilya Maximets wrote: > >>>> On 9/4/20 12:05 AM, Flavio Leitner wrote: > >>>>> On Thu, Sep 03, 2020 at 11:20:56PM +0200, Ilya Maximets wrote: > >>>>>> On 6/11/20 1:45 AM, Flavio Leitner wrote: > >>>>>>> The test 'Check Python IDL reconnects to leader - Python3 > >>>>>>> (leader only)' fails sometimes when the first ovsdb-server > >>>>>>> gets killed before the others had joined the cluster. > >>>>>>> > >>>>>>> Fix the function ovsdb_cluster_start_idltest to wait them > >>>>>>> to join the cluster. > >>>>>> > >>>>>> Hi, Flavio. Thanks for the fix and sorry for delays. > >>>>>> > >>>>>> Patch seems OK, but I'm not very comfortable with the code duplication > >>>>>> between this function and OVS_WAIT_UNTIL macro. Have you considered > >>>>>> conversion of ovsdb_cluster_start_idltest() function into m4_define() > >>>>>> macro so we could easily use OVS_WAIT_UNTIL inside of it? > >>>>> > >>>>> I tried, but I ran into issues and I am not familiar with m4. > >>>> > >>>> Could you try following diff: > >>> > >>> I tried, but it fails. The test logs are here: > >>> http://people.redhat.com/~fleitner/2127.tar.bz2 > >> > >> Oh, sorry, my fault. We can't use shell expansions over m4 definitions. > >> Should work with following change: > > > > No worries! > > > > The test passes all times with the fix below. > > Great! Would you mind sending v2?
Done: https://mail.openvswitch.org/pipermail/ovs-dev/2020-September/374572.html fbl _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
