On Sat, Sep 12, 2020 at 11:19 AM Han Zhou <[email protected]> wrote: > If chassis_rec is NULL but chassis_private_rec is not, chassis_rec->name > is a NULL pointer deference. This patch fixes it. > > Fixes: 4adc10f581 ("Avoid nb_cfg update notification flooding") > Signed-off-by: Han Zhou <[email protected]> >
Acked-by: Numan Siddique <[email protected]> Numan > --- > v1 -> v2: Address the comment from Ilya for coding style. > > controller/chassis.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/controller/chassis.c b/controller/chassis.c > index 8e6ad2d..a365188 100644 > --- a/controller/chassis.c > +++ b/controller/chassis.c > @@ -843,7 +843,8 @@ chassis_cleanup(struct ovsdb_idl_txn *ovnsb_idl_txn, > if (ovnsb_idl_txn) { > ovsdb_idl_txn_add_comment(ovnsb_idl_txn, > "ovn-controller: unregistering chassis > '%s'", > - chassis_rec->name); > + chassis_rec ? chassis_rec->name > + : chassis_private_rec->name); > if (chassis_rec) { > sbrec_chassis_delete(chassis_rec); > } > -- > 2.1.0 > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
