Bleep bloop. Greetings Alin Gabriel Serdean, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 128 characters long (recommended limit is 79)
#64 FILE: windows/ovs-windows-installer/Product.wxs:40:
<RegistrySearch Id="Test" Root="HKLM" Key="SOFTWARE\Microsoft\Windows
NT\CurrentVersion" Name="CurrentBuild" Type="raw" />
WARNING: Line is 88 characters long (recommended limit is 79)
#82 FILE: windows/ovs-windows-installer/Product.wxs:261:
<Condition><![CDATA[(VersionNT = "603") AND (BUILDNUMBER <
10000)]]></Condition>
WARNING: Line is 92 characters long (recommended limit is 79)
#87 FILE: windows/ovs-windows-installer/Product.wxs:266:
<Component Id='OpenvSwitchDriver_Win10'
Guid='{7A1E2446-8196-4738-8362-5CFD55896A7D}'>
WARNING: Line is 130 characters long (recommended limit is 79)
#89 FILE: windows/ovs-windows-installer/Product.wxs:268:
<File Id='win10_ovsext.sys' Name='ovsext.sys' DiskId='1'
Source='Driver\Win10\ovsext.sys' Checksum='yes' KeyPath='yes'/>
WARNING: Line is 117 characters long (recommended limit is 79)
#90 FILE: windows/ovs-windows-installer/Product.wxs:269:
<File Id='win10_ovsext.inf' Name='ovsext.inf' DiskId='1'
Source='Driver\Win10\ovsext.inf' Checksum='yes' />
WARNING: Line is 117 characters long (recommended limit is 79)
#91 FILE: windows/ovs-windows-installer/Product.wxs:270:
<File Id='win10_ovsext.cat' Name='ovsext.cat' DiskId='1'
Source='Driver\Win10\ovsext.cat' Checksum='yes' />
Lines checked: 98, Warnings: 6, Errors: 0
Please check this out. If you feel there has been an error, please email
acon...@redhat.com
Thanks,
0-day Robot
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
