On Fri, Sep 18, 2020 at 9:54 AM Gurucharan Shetty <[email protected]> wrote: > > Currently, we terminate a daemon by trying > "ovs-appctl exit", "SIGTERM" and finally "SIGKILL". > But the logic fails if during "ovs-appctl exit", the > daemon crashes (segfaults). The monitor will automatically > restart the daemon with a new pid. The current logic of > checking the non-existance of old pid succeeds and we proceed > with the assumption that the daemon is dead. > > This is a problem during OVS upgrades as we will continue > to run the older version of OVS. > > With this commit, we take care of this situation. If there > is a segfault, the pidfile is not deleted. So, we wait a > little to give time for the monitor to restart the daemon > (which is usually instantaneous) and then re-read the pidfile. > > VMware-BZ: #2633995 > Signed-off-by: Gurucharan Shetty <[email protected]> > ---
Thanks for the patch. I think it does fix a case when --monitor is specified and ovs crash during "ovs-appctl exit". Acked-by: Yi-Hung Wei <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
