> > On 9/19/20 8:08 AM, Linhaifeng wrote: > > 1. include config.h to avoid include different atomic head file > > All .c files should include config.h as their first include, so config.h > should always > be already included at the time we including ovs-atomic.h. Do you know the .c > file that doesn't include config.h? > If so, please, fix it instead. Header files should not include config.h by > themselves. >
OK. Thank you. > > 2. __GNUC__ == 4 is enough > > This is technically correct, but it doesn't worth the work for fixing it > unless > you're fixing some real issue at the same time. > OK. Thank you. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
