On 21/09/2020 20:15, Han Zhou wrote: > On Mon, Sep 21, 2020 at 2:19 AM Mark Gray <[email protected]> wrote: >> >> On 14/09/2020 19:12, Numan Siddique wrote: >>> On Mon, Sep 14, 2020 at 10:18 PM Dumitru Ceara <[email protected]> > wrote: >>> >>>> On 9/12/20 9:10 AM, Mark Gray wrote: >>>>> runtime_data_sb_datapath_binding_handler() only handles deletion of .. > > Hi Mark, what do you mean by "query the flow-table"? > Here I think we can simply check if the record is updated, i.e.: > > !sbrec_datapath_binding_is_new() && !sbrec_datapath_binding_is_deleted() > > then return false (trigger recompute) to ensure the correctness. >
Hi Han, I originally tried to do this but it triggered failures in other unit tests. I assumed it was because I misunderstood when this table was getting updated for other use cases and,therefore, I needed to have a more specific check. However based on your feedback, I looked at this again and realised the _is_new() function was never returning 'true'. I spent some time root-causing and found that it was an issue in the OVSDB IDL code. I have submitted a patch to fix - it would be great if you could review because I think you are familiar with the code. It's at https://mail.openvswitch.org/pipermail/ovs-dev/2020-September/375645.html. I have another patch ready for 'ovn-controller: Handle changes in requested-tnl-key' satisfying all the review comments but I will wait until 'ovsdb-idl: Fix *_is_new() IDL functions' has been committed before reposting. Mark _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
