On 10/1/20 12:40 PM, Mark Gray wrote: > On 01/10/2020 11:37, Dumitru Ceara wrote: >> On 10/1/20 12:19 PM, Mark Gray wrote: >>> On 30/09/2020 11:56, Dumitru Ceara wrote: > >>> >>> On failure do we need to undo the flow_resource_add()? >>> >> >> We didn't do before and I think it's fine to leave as is because failure >> to parse will trigger a recompute of the I-P engine and call >> en_flow_output_run() which should cleanup the resource refs. >> >> Unfortunately I don't see an easier way to do cleanup. >> >> I'll send a v2 soon fixing the points above. > > Ok, sounds good. Also, I ran the UTs and don't see any issues/failures. >
v2 available at: http://patchwork.ozlabs.org/project/ovn/patch/[email protected]/ Thanks, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
