On 10/26/20 6:56 PM, Ben Pfaff wrote: > This can make it easier to see what daemon is committing transactions. > Sometimes, in OVN especially, it can be hard to guess. > > Signed-off-by: Ben Pfaff <[email protected]> > --- > lib/ovsdb-idl.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c > index d8f221ca6073..fdb9d85f5ccc 100644 > --- a/lib/ovsdb-idl.c > +++ b/lib/ovsdb-idl.c > @@ -5521,6 +5521,9 @@ ovsdb_idl_loop_run(struct ovsdb_idl_loop *loop) > || ovsdb_idl_get_seqno(loop->idl) == loop->skip_seqno > ? NULL > : ovsdb_idl_txn_create(loop->idl)); > + if (loop->open_txn) { > + ovsdb_idl_txn_add_comment(loop->open_txn, "%s", program_name); > + } > return loop->open_txn; > } > >
Looks good to me, thanks! Once this is applied, we should probably remove the explicit program name we pass to ovsdb_idl_txn_add_comment() in some places in OVN but that's a different story I guess. Acked-by: Dumitru Ceara <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
