Hi Terry

Acked-by: Mark Michelson <[email protected]>

On 10/27/20 12:16 PM, Terry Wilson wrote:
Just bumping to make sure this doesn't fall through the cracks. 11 days
since the last ack. Let me know if there's anything else that needs
changing. Thanks!

On Fri, Oct 16, 2020 at 1:37 AM Thomas Neuman <[email protected]>
wrote:

Yup, fair enough. LGTM

Acked-by: Thomas Neuman <[email protected]>


I get why it seems a little weird, but the reason I chose @staticmethod
is
because @classmethod would imply that we are going to actually reference
the class that is passed in the first argument, and we won't. The only
thing this method depends on is the socket, so it seemed a staticmethod
that could be overridden in a subclass with a special need was the way to
go.


_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev


_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev


_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to