Bleep bloop. Greetings Harry van Haaren, I am a robot and I have tried out your patch. Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #88 FILE: lib/dpif-netdev-lookup-avx512-gather.c:101: uint32_t c = _mm512_mask_cmpeq_epi64_mask(lane_mask_gt8, v_data, v_key); ERROR: Improper whitespace around control block #97 FILE: lib/dpif-netdev-lookup-avx512-gather.c:110: #define DUMP_ZMM(name, zmm) do { } while(0) ERROR: Improper whitespace around control block #106 FILE: lib/dpif-netdev-lookup-avx512-gather.c:119: } while(0) ERROR: C99 style comment #114 FILE: lib/dpif-netdev-lookup-avx512-gather.c:127: avx512_blocks_gather(__m512i v_u0, // reg of u64 of all u0 bits ERROR: C99 style comment #115 FILE: lib/dpif-netdev-lookup-avx512-gather.c:128: __m512i v_u1, // reg of u64 of all u1 bits ERROR: C99 style comment #116 FILE: lib/dpif-netdev-lookup-avx512-gather.c:129: const uint64_t *pkt_blocks, // ptr pkt blocks to load ERROR: C99 style comment #117 FILE: lib/dpif-netdev-lookup-avx512-gather.c:130: const void *tbl_blocks, // ptr to blocks in tbl to & with ERROR: C99 style comment #118 FILE: lib/dpif-netdev-lookup-avx512-gather.c:131: const void *tbl_mf_masks, // ptr to subtable mf masks ERROR: C99 style comment #119 FILE: lib/dpif-netdev-lookup-avx512-gather.c:132: __mmask64 u1_bcast_mask, // mask of lanes to use u1 ERROR: C99 style comment #120 FILE: lib/dpif-netdev-lookup-avx512-gather.c:133: const uint64_t pkt_mf_u0_pop, // num bits in u0 of pkt ERROR: C99 style comment #121 FILE: lib/dpif-netdev-lookup-avx512-gather.c:134: __mmask64 zero_mask, // maskz as pkt not have mf bit set ERROR: C99 style comment #122 FILE: lib/dpif-netdev-lookup-avx512-gather.c:135: __mmask64 u64_lanes_mask) // total lane count to use WARNING: Line is 80 characters long (recommended limit is 79) #130 FILE: lib/dpif-netdev-lookup-avx512-gather.c:143: __m512i v_pkt_bits = _mm512_mask_blend_epi64(u1_bcast_mask, v_u0, v_u1); WARNING: Line is 88 characters long (recommended limit is 79) ERROR: C99 style comment #201 FILE: lib/dpif-netdev-lookup-avx512-gather.c:208: //printf("tbl u0 %x, u1 %x, bit count total %d\n", tbl_u0, tbl_u1, bit_count_total); WARNING: Line is 81 characters long (recommended limit is 79) #256 FILE: lib/dpif-netdev-lookup-avx512-gather.c:236: const uint64_t zero_mask_wip = (u1_to_zero << bit_count_u0) | u0_to_zero; WARNING: Line is 80 characters long (recommended limit is 79) ERROR: C99 style comment #284 FILE: lib/dpif-netdev-lookup-avx512-gather.c:264: &pkt_blocks[0],// TODO: how? Lines checked: 355, Warnings: 5, Errors: 13 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev