On Mon, Nov 09, 2020 at 02:44:53PM +0100, Dumitru Ceara wrote: > On 11/6/20 4:36 AM, Ben Pfaff wrote: > > From: Leonid Ryzhyk <[email protected]> > > > > This implementation is incremental, meaning that it only recalculates > > what is needed for the southbound database when northbound changes > > occur. It is expected to scale better than the C implementation, > > for large deployments. (This may take testing and tuning to be > > effective.) > > > > There are three tests that I'm having mysterious trouble getting > > to work with DDlog. For now, I've marked the testsuite to skip > > them unless RUN_ANYWAY=yes is set in the environment. > > > > Signed-off-by: Leonid Ryzhyk <[email protected]> > > Co-authored-by: Justin Pettit <[email protected]> > > Signed-off-by: Justin Pettit <[email protected]> > > Co-authored-by: Ben Pfaff <[email protected]> > > Signed-off-by: Ben Pfaff <[email protected]> > > --- > > As discussed on v2 some tests fail. Quite a few are indeed because of > races in the tests themselves. For a couple of the OVN test failures I > sent a patch to fix them. If you prefer I can also send it as an > incremental to your series: > > http://patchwork.ozlabs.org/project/ovn/list/?series=213114
Thanks, I sent a review for this just now. > There are a few others that are ddlog-related: > > 145: ovn -- /32 router IP address -- ovn-northd-ddlog FAILED > (ovs-macros.at:231) > > This is because the following logical flows are not added to the SB by > ovn-northd-ddlog: > table=14(ls_in_arp_rsp ), priority=100 , match=(arp.tpa == > 10.0.0.2 && arp.op == 1 && inport == "alice1"), action=(next;) > table=14(ls_in_arp_rsp ), priority=50 , match=(arp.tpa == > 10.0.0.2 && arp.op == 1), action=(eth.dst = eth.src; eth.src = > f0:00:00:01:02:04; arp.op = 2; /* ARP reply */ arp.tha = arp.sha; > arp.sha = f0:00:00:01:02:04; arp.tpa = arp.spa; arp.spa = 10.0.0.2; > outport = inport; flags.loopback = 1; output;) > > 213: ovn -- IGMP snoop/querier/relay -- ovn-northd-ddlog FAILED > 215: ovn -- MLD snoop/querier/relay -- ovn-northd-ddlog FAILED > > These happen because the following commit is not yet ported to northd-ddlog: > https://github.com/ovn-org/ovn/commit/97778ab3e422ac071faa67f9f477fd54977e9c04 Thanks for identifying that. I thought I was caught up. I'll fix it. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
