On 11/10/20 1:47 AM, Ben Pfaff wrote: > On Mon, Nov 09, 2020 at 02:43:43PM +0100, Dumitru Ceara wrote: >> Fix some of the race conditions that are present in the current OVN test >> suite. >> >> Signed-off-by: Dumitru Ceara <[email protected]> > > Thanks! > > I think I see some problems (I did not test this). First, I'm surprised > this works, since I would expect m4 to drop the [], so that they'd need > to be doubled into [[]]: > > sed 's/conjunction([0-9]\+,[0-9]\+\/[0-9]\+)/conjunction()/g' > > Second, \+ is a GNU sed extension. Usually we avoid GNU extensions > since sometimes people want to run OVS (and maybe OVN?) with BSD. The > portable way to write it is \{1,\}. >
You're right, sorry, I didn't test this properly. sed wasn't matching anything with my change. > Maybe it would be easier to write s/conjunction([^)]*)/conjunction()/g, > doubling the [] if necessary. > This is way better indeed. I'll use it in v2. Thanks, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
