On Tue, Nov 10, 2020 at 7:54 PM Renat Nurgaliyev <[email protected]> wrote: > > Set initial SB and NB DBs probe interval to 0 to avoid connection > flapping. > > Before configured in northd_probe_interval value is actually applied > to southbound and northbound database connections, both connections > must be fully established, otherwise ovnnb_db_run() will return > without retrieving configuration data from northbound DB. In cases > when southbound database is big enough, default interval of 5 seconds > will kill and retry the connection before it is fully established, no > matter what is set in northd_probe_interval. Client reconnect will > cause even more load to ovsdb-server and cause cascade effect, so > northd can never stabilise. We have more than 2000 ports in our lab, > and northd could not start before this patch, holding at 100% CPU > utilisation both itself and ovsdb-server. > > After connections are established, any value in northd_probe_interval, > or default DEFAULT_PROBE_INTERVAL_MSEC is applied correctly. > > Signed-off-by: Renat Nurgaliyev <[email protected]> > --- > v2: > - Resubmitting patch because git am failed last time > v3: > - Resubmitting patch because mail client broke formatting > v4: > - Resubmitting patch because mail client broke formatting once again. > I switched to mutt and it won't happen again, I promise guys. > v5: > - Fixed signoff. > ---
Thanks. I applied this patch to master. Numan > northd/ovn-northd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c > index 684c2bd47..073c6a0f3 100644 > --- a/northd/ovn-northd.c > +++ b/northd/ovn-northd.c > @@ -100,7 +100,7 @@ static struct eth_addr svc_monitor_mac_ea; > > /* Default probe interval for NB and SB DB connections. */ > #define DEFAULT_PROBE_INTERVAL_MSEC 5000 > -static int northd_probe_interval_nb = DEFAULT_PROBE_INTERVAL_MSEC; > -static int northd_probe_interval_sb = DEFAULT_PROBE_INTERVAL_MSEC; > +static int northd_probe_interval_nb = 0; > +static int northd_probe_interval_sb = 0; > > #define MAX_OVN_TAGS 4096 > -- > 2.29.2 > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
