On Wed, Nov 11, 2020 at 01:03:56PM +0530, Numan Siddique wrote:
> On Wed, Nov 11, 2020 at 6:49 AM Ben Pfaff <[email protected]> wrote:
> >
> > The example for the fwd_group action was obviously wrong (it needed a
> > closing parenthesis and semicolon) and then when I looked closer I saw
> > other issues:
> >
> >   - It's weird to insist on "true" or "false" in quotation marks (why?)
> >     and the example didn't show that.
> >
> >   - The example didn't show that port names need to be quoted.
> >
> >   - The implementation didn't allow specifying liveness=false (why?)
> >     or liveness="false" and the test even checked for that.
> >
> > This fixes all that stuff.  For backward compatibility, it still accepts
> > "true" (and "false") in quotation marks, but now accepts without as well
> > for future use.
> >
> > Signed-off-by: Ben Pfaff <[email protected]>
> 
> Oops. Thanks for fixing this.
> 
> Acked-by: Numan Siddique <[email protected]>

Thanks.  I applied this to OVN master.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to