On Thu, Nov 12, 2020 at 09:58:22AM +0100, Dumitru Ceara wrote: > On 11/12/20 2:45 AM, Ben Pfaff wrote: > > "==" is a GNU extension to "test". A pox upon it. > > :) > > Interesting, I didn't know this and had to dig quite a bit because it's > not explicitly mentioned: > > https://www.gnu.org/software/coreutils/manual/coreutils.html#String-tests
I didn't know it wasn't documented. Maybe I will submit a documentation patch. > Whereas in the posix spec "==" doesn't show up: > > https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html > > > > > Signed-off-by: Ben Pfaff <[email protected]> > > --- > > In any case: > > Acked-by: Dumitru Ceara <[email protected]> Thanks! I noticed one more place to fix: diff --git a/utilities/ovn-sim.in b/utilities/ovn-sim.in index a05e4cd8a425..c87e075e52d1 100755 --- a/utilities/ovn-sim.in +++ b/utilities/ovn-sim.in @@ -241,7 +241,7 @@ EOF export -f ovn_start ovn_attach() { - if test "$1" == --help; then + if test "$1" = --help; then cat <<EOF $FUNCNAME: attach default sandbox to an interconnection network for OVN usage: $FUNCNAME NETWORK BRIDGE IP [MASKLEN] I folded that one in and applied this to OVN master. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
