On 16/11/2020 16:33, Ilya Maximets wrote: > On 11/16/20 5:28 PM, Stokes, Ian wrote: >>> On Wed, 11 Nov 2020 04:25:30 -0500 >>> Mark Gray <mark.d.g...@redhat.com> wrote: >>> >>>> ovs/dirs.py should be auto-generated using the template >>>> ovs/dirs.py.template at build time. This will set the >>>> ovs.dirs python variables with a value specified by the >>>> environment or, if the environment variable is not set, from >>>> the build system. >>>> >>>> Signed-off-by: Mark Gray <mark.d.g...@redhat.com> >>> >>> Acked-By: Timothy Redaelli <tredae...@redhat.com> >>> >> >> Thanks Timothy, I've pushed this series to master now. > > Thanks, Ian. But we might need a follow up on this change. > I think, the main reason why dirs.py existed is that we need > it while doing setup of python package, i.e. we should have > it during execution of python/ovs/setup.py. Setup script > already checks if version.py exists, and we might want check > for dirs.py too, otherwise python package will be non-functional.
This means that dirs.py was never being called from setup.py but it was at least (always) there. Looking at ovs-monitor-ipsec which uses the python bindings, it does `import dirs.py` which means this may be how python applications are using it. Also, I think the automake system should ensure that dirs.py is there when packaging but its good to include this change I think. I submit a patch to fix this: https://patchwork.ozlabs.org/project/openvswitch/patch/20201116170026.331164-1-mark.d.g...@redhat.com/ > > Also, gitignore file seems to have dir.py and not dirs.py. > > Best regards, Ilya Maximets. > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
