On 11/19/20 6:13 AM, Ben Pfaff wrote: > From: Leonid Ryzhyk <[email protected]> > > This implementation is incremental, meaning that it only recalculates > what is needed for the southbound database when northbound changes > occur. It is expected to scale better than the C implementation, > for large deployments. (This may take testing and tuning to be > effective.) > > There are three tests that I'm having mysterious trouble getting > to work with DDlog. For now, I've marked the testsuite to skip > them unless RUN_ANYWAY=yes is set in the environment. > > Signed-off-by: Leonid Ryzhyk <[email protected]> > Co-authored-by: Justin Pettit <[email protected]> > Signed-off-by: Justin Pettit <[email protected]> > Co-authored-by: Ben Pfaff <[email protected]> > Signed-off-by: Ben Pfaff <[email protected]> > Acked-by: Dumitru Ceara <[email protected]>
Hi Ben, This is not a review, just a note that my "Acked-by" should probably go to patch 2/5 "tests: Prepare for multiple northd types.". Unless I'm mistaken, I didn't review the last patch of the series yet, except the fact that I tried running the OVN tests. I'm not saying patch 5/5 "ovn-northd-ddlog: New implementation of ovn-northd based on ddlog." is not good, just that I didn't review it yet :) Thanks, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
