Acked-by: Ankur Sharma <[email protected]>

Regards,
Ankur
________________________________
From: Ilya Maximets <[email protected]>
Sent: Thursday, November 19, 2020 4:17 PM
To: [email protected] <[email protected]>
Cc: Mark Michelson <[email protected]>; Numan Siddique <[email protected]>; 
Dumitru Ceara <[email protected]>; Ilya Maximets <[email protected]>; Ankur 
Sharma <[email protected]>
Subject: [PATCH ovn 11/14] ovn-nbctl: Fix leak of IPs while configuring NAT.

CC: Ankur Sharma <[email protected]>
Fixes: 20bc58a67f39 ("External IP based NAT: Add Columns and CLI")
Signed-off-by: Ilya Maximets <[email protected]>
---
 utilities/ovn-nbctl.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c
index fb6766839..89537edf0 100644
--- a/utilities/ovn-nbctl.c
+++ b/utilities/ovn-nbctl.c
@@ -4601,8 +4601,11 @@ nbctl_lr_nat_set_ext_ips(struct ctl_context *ctx)
             } else {
                 nbrec_nat_set_allowed_ext_ips(nat, addr_set);
             }
+            free(nat_ip);
+            free(old_ip);
             return;
         }
+        free(old_ip);
     }

     if (!nat_found) {
--
2.25.4

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to