On Thu, Nov 12, 2020 at 5:25 PM Dumitru Ceara <[email protected]> wrote: > > On 10/28/20 9:02 AM, Dumitru Ceara wrote: > > On 10/23/20 12:20 PM, Dumitru Ceara wrote: > >> From: Vasu Dasari <[email protected]> > >> > >> Upstream OVS commit: > >> commit c99d14775f78cb38b2109add063f58201ba07652 > >> Author: Vasu Dasari <[email protected]> > >> Date: Mon Jul 15 17:15:01 2019 -0400 > >> > >> ovs-macros: An option to suspend test execution on error > >> > >> Origins for this patch are captured at > >> > >> https://mail.openvswitch.org/pipermail/ovs-discuss/2019-June/048923.html. > >> > >> Summarizing here, when a test fails, it would be good to pause test > >> execution > >> and let the developer poke around the system to see current status of > >> system. > >> > >> As part of this patch, made a small tweaks to ovs-macros.at, so that > >> when test > >> suite fails, ovs_on_exit() function will be called. And in this > >> function, a check > >> is made to see if an environment variable to OVS_PAUSE_TEST is set. If > >> it is > >> set, then test suite is paused and will continue to wait for user input > >> Ctrl-D. Meanwhile user can poke around the system to see why test case > >> has > >> failed. Once done with investigation, user can press ctrl-d to cleanup > >> the > >> test suite. > >> > >> For example, to re-run test case 139: > >> > >> export OVS_PAUSE_TEST=1 > >> cd tests/system-userspace-testsuite.dir/139 > >> sudo -E ./run > >> > >> When error occurs, above command would display something like this: > >> ===================================================== > >> Set environment variable to use various ovs utilities > >> export > >> OVS_RUNDIR=/opt/vdasari/Developer/ovs/_build-gcc/tests/system-userspace-testsuite.dir/139 > >> Press ENTER to continue: > >> > >> ===================================================== > >> And from another window, one can execute ovs-xxx commands like: > >> export > >> OVS_RUNDIR=/opt/vdasari/Developer/ovs/_build-gcc/tests/system-userspace-testsuite.dir/139 > >> $ ovs-ofctl dump-ports br0 > >> . > >> . > >> > >> To be able to pause while performing `make check`, one can do: > >> $ OVS_PAUSE_TEST=1 make check TESTSUITEFLAGS='-v' > >> > >> Acked-by: Aaron Conole <[email protected]> > >> Signed-off-by: Vasu Dasari <[email protected]> > >> Signed-off-by: Ben Pfaff <[email protected]> > >> > >> Signed-off-by: Dumitru Ceara <[email protected]>
Thanks Dumitru. I applied this patch to master (making you as the author of the patch) as the commit message captures the original patch details from OVS. Thanks Numan > > > > Hi Vasu, > > > > Due the way I cherry-picked this patch when porting it for the OVN repo, > > when > > applied, it will appear as authored by you. > > > > Would you be ok with this, i.e., would you be ok adding your > > "signed-off-by"? > > > > Ping :) > > Thanks, > Dumitru > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
